Add sorting feature to Bundles table in Gate22#176
Add sorting feature to Bundles table in Gate22#176Sidhi-03 wants to merge 2 commits intoaipotheosis-labs:mainfrom
Conversation
|
@Sidhi-03 is attempting to deploy a commit to the Proxy Team on Vercel. A member of the Team first needs to authorize it. |
There was a problem hiding this comment.
Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.
WalkthroughThe change modifies the MCPServerBundle table in the bundle-mcp dashboard page by converting static header strings to interactive React components that render clickable buttons with sorting icons (ArrowUpDown), enabling users to toggle column sorting. A custom sorting function is added for the configurations column to sort by array length. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes
Possibly related issues
Poem
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
♻️ Duplicate comments (1)
frontend/src/app/(dashboard)/bundle-mcp/page.tsx (1)
169-177: Apply the same accessibility improvements here.This sort button has the same accessibility and UX concerns as the NAME column header. Please apply the same ARIA attributes and consider dynamic sort icons.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
frontend/src/app/(dashboard)/bundle-mcp/page.tsx(3 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
- GitHub Check: cubic · AI code reviewer
- GitHub Check: Format & Lint
- GitHub Check: Compose Tests
🔇 Additional comments (1)
frontend/src/app/(dashboard)/bundle-mcp/page.tsx (1)
188-192: LGTM! Well-implemented custom sorting function.The custom
sortingFncorrectly sorts by array length with proper null-safety handling using optional chaining and fallback values.
|
@coderabbitai generate docstrings |
✅ Actions performedInitiated docstring generation; will generate only if new commits exist. |
|
Note Docstrings generation - SUCCESS |
Docstrings generation was requested by @Sidhi-03. * #176 (comment) The following files were modified: * `frontend/src/app/(dashboard)/bundle-mcp/page.tsx`
|
@ObnoxiousProxy Could you please review this PR |
🏷️ Ticket
#145
🔗 Link to Issue
📝 Description
Added sorting functionality to the MCP Bundles listing table to enable users to quickly find bundles by:
Changes Made
File: frontend/src/app/(dashboard)/bundle-mcp/page.tsx
Checklist
✅ I have signed the Contributor License Agreement (CLA) and read the contributing guide (required)
✅ I have linked this PR to an issue or a ticket (required)
✅ I have updated the documentation related to my change if needed
✅ I have updated the tests accordingly (required for a bug fix or a new feature)
All checks on CI passed
✅ ESLint: No warnings or errors
✅ Prettier: All files formatted
✅ Build: Compiled successfully
Summary by cubic
Added sorting to the MCP Bundles table so users can quickly find bundles by name, configuration count, and created date. Addresses #145.
Written for commit 15f0ca1. Summary will update automatically on new commits.
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.